login forum

[armyman]

i got this hole thing from my frind when i try to use it it says

Notice: Undefined variable: action in c:\program files\apache group\Apache\htdocs\login_gam.php on line 4

heres the main login thing:

<?php 
include('config.php');

if($action == "submit"){
	if(($userinput == "")||($passinput == "")){
	echo "$noinfo";
	} else {
		if(($userinput == $username)&&($passinput == $password)){
		header( "Location: $location" );
		} else {
		echo "$badinfo";
		}
	}
}
include('form.php')	;
?>

hers the forum_gam.php file

 <form name="form1" method="post" action="">
  <p>Username:  
    <input name="userinput" type="text" id="userinput">
    <br>
    <br>
  Password: 
  <input name="passinput" type="password" id="passinput">
  <br>
  <br>
  <input type="submit" name="Submit" value="Submit">
  <input type="reset" name="Reset" value="Reset">
  <input name="action" type="hidden" id="action" value="submit">
  </p>
  </form>

annd here is the config_gam.php

  <?php

$username = "test";
$password = "test";
$location = "http://localhost:81/upload.php";
$badinfo = "Bad Info!!!!!!!";
$noinfo = "No Info Here";

some one see what is wrong?

[SeeIT Solutions]

Basically, it was poorly written code, it assumed global variables was on, and the default setting is off.

<?php 
include('config.php');

if($_POST['action'] == "submit"){
	if(($_POST['userinput'] == "")||($_POST['passinput'] == "")){
	echo "$noinfo";
	} else {
		if(($_POST['userinput'] == $username)&&($_POST['passinput'] == $password)){
		header( "Location: $location" );
		} else {
		echo "$badinfo";
		}
	}
}
include('form.php')	;
?>

Try that

[dumpfi]

If you have register_globals = Off in your php.ini you must use $_POST['action'] instead of just $action (the other values from the form in the same way).

Oh, and I advise you not to change the settings in the php.ini in favour of adjusting your script, because there are security issues with activating register_globals.

dumpfi

Edit: Too slow.. i need a secretary (a good looking one *g*)

[armyman]

its still showing


Notice: Undefined index: action in c:\program files\apache group\Apache\htdocs\login_gam.php on line 4

[armyman]

well im at it any one know how to cover how to make it so they dont see the real page so they can just go to it??? iv seen it befor