Tweet
Tab Gallery onclick event
I was trying to help someone on another forum and seem to have run into a brick wall. 
The main problem that has got me stumped at the moment is that clicking on the images in the 1st tab work fine.
However the subsequent tab selections and clicks do not change the "bigImage" correctly (not at all).
Perhaps some other more experienced forum members can identify what I doing wrong at this time.
I believe it is in my set-up of the onclick events in the "onload=" section, but I not the best at this event stuff yet!
Here is the full code that 'almost' works:
The main problem that has got me stumped at the moment is that clicking on the images in the 1st tab work fine.
However the subsequent tab selections and clicks do not change the "bigImage" correctly (not at all).
Perhaps some other more experienced forum members can identify what I doing wrong at this time.
I believe it is in my set-up of the onclick events in the "onload=" section, but I not the best at this event stuff yet!
Code:
var sel, tmp, elem;
var j=0;
for (var i=0; i<imgGroupArray.length; ++i) {
sel = document.getElementById('imgGroup'+i).getElementsByTagName('img');
while (elem=sel[j++]) { elem.onclick = function() { setBigImage(this.src); } }
}
Code:
<!DOCTYPE HTML>
<html>
<head>
<title> Tab Gallery </title>
<style type="text/css">
li { display:inline; list-style-type:none; border:1px solid blue; margin:3px; }
.imgBlock { display:none; }
</style>
<script type="text/javascript">
// From: http://www.webdeveloper.com/forum/showthread.php?t=250787
var baseURL = 'http://www.nova.edu/hpd/otm/pics/4fun/';
var imgGroupArray = [
['11.jpg','12.jpg','13.jpg','14.jpg','15.jpg'],
['21.jpg','22.jpg','23.jpg','24.jpg','25.jpg'],
['31.jpg','32.jpg','33.jpg','34.jpg','35.jpg'],
['41.jpg','42.jpg','43.jpg','44.jpg','45.jpg'],
['51.jpg','52.jpg','53.jpg','54.jpg','55.jpg'],
['61.jpg','62.jpg','63.jpg','64.jpg','65.jpg'] // NOTE: No comma after last entry
];
function tabGroup(which) {
var sel = document.getElementById('imgGroup').getElementsByTagName('div');
for (var i=0; i<sel.length; ++i) {
sel[i].style.display = 'none';
}
var tmp = 'imgGroup'+which; // alert(tmp);
document.getElementById(tmp).style.display = 'block';
}
function setBigImage(info) { // alert(info);
document.getElementById('bigImage').src = info;
}
window.onload = function() {
var img;
for (var i=0; i<imgGroupArray.length; ++i) {
for (var j=0; j<imgGroupArray[i].length; ++j) {
img = document.createElement('img');
img.setAttribute('src', baseURL+imgGroupArray[i][j]);
img.setAttribute('height','100px');
img.setAttribute('width','75px');
document.getElementById('imgGroup'+i).appendChild(img);
}
}
// Following modified from:
// http://www.codingforum.net/showthread.php?t=102896&highlight=addevent+onclick
var sel, tmp, elem;
var j=0;
for (var i=0; i<imgGroupArray.length; ++i) {
sel = document.getElementById('imgGroup'+i).getElementsByTagName('img');
while (elem=sel[j++]) { elem.onclick = function() { setBigImage(this.src); } }
}
tabGroup(0);
}
</script>
</head>
<body>
<div id="tabMenu">
<div style="float:left">
<li onclick="tabGroup(0)">Tab 1</li>
<li onclick="tabGroup(1)">Tab 2</li>
<li onclick="tabGroup(2)">Tab 3</li>
<li onclick="tabGroup(3)">Tab 4</li>
<li onclick="tabGroup(4)">Tab 5</li>
<li onclick="tabGroup(5)">Tab 6</li>
</div><br>
<div id="imgGroup"
style="width:300px; height:300px; border:1px solid red; float:left">
<div id="imgGroup0" class="imgBlock"></div>
<div id="imgGroup1" class="imgBlock"></div>
<div id="imgGroup2" class="imgBlock"></div>
<div id="imgGroup3" class="imgBlock"></div>
<div id="imgGroup4" class="imgBlock"></div>
<div id="imgGroup5" class="imgBlock"></div>
</div>
<div id="bigImageDiv"
style="width:250px; height:300px; border:1px solid red; float:left;">
<img id="bigImage" src="" alt="bigImage here!">
</div>
<br style="clear:both">
</div>
</body>
</html>
Comment