Global var from within a function

[beedie]

I have a function that is passed a variable.

I need to then make the variable global so it is available to another function

function getspecial([COLOR="Red"]str[/COLOR])
{
  
xmlHttp=GetXmlHttpObject()
if (xmlHttp==null)
 {
 alert ("Browser does not support HTTP Request")
 return
 }
var url="index.php/home/getSpecial/"
url=url+str

xmlHttp.onreadystatechange=stateChanged 
xmlHttp.open("GET",url,true)
xmlHttp.send(null)
}

function stateChanged() 
{ 
if (xmlHttp.readyState==4 || xmlHttp.readyState=="complete")
 { 
 document.getElementById([COLOR="Red"]str[/COLOR]).innerHTML=xmlHttp.responseText 
 } 
}

How do i get str into the next function as shown in red?
Help much appreciated.

[venegal]

Within the getspecial function you could declare stateChangedStr() = new Function ( "stateChanged(str);" ); and call it like that: xmlHttp.onreadystatechange=stateChangedStr;

[beedie]

What am I missing venegal?
Tx for you idea.
I am a noobie javascript

function getspecial(str)
{
stateChangedStr() = new Function ( "stateChanged(str);" );
xmlHttp=GetXmlHttpObject()
if (xmlHttp==null)
 {
 alert ("Browser does not support HTTP Request")
 return
 }
var url="index.php/home/getSpecial/"
url=url+str

xmlHttp.onreadystatechange=stateChangedStr; 
xmlHttp.open("GET",url,true)
xmlHttp.send(null)
}
function stateChanged() 
{ 
if (xmlHttp.readyState==4 || xmlHttp.readyState=="complete")
 { 
 document.getElementById('??').innerHTML=xmlHttp.responseText 
 } 
}

[rnd me]

you only need to move one char for it to work:

function getspecial(str)
{
  
[COLOR="Red"]var [/COLOR]xmlHttp=GetXmlHttpObject()
if (xmlHttp==null)
 {
 alert ("Browser does not support HTTP Request")
 return
 }
var url="index.php/home/getSpecial/"
url=url+str

xmlHttp.onreadystatechange=stateChanged 
xmlHttp.open("GET",url,true)
xmlHttp.send(null)


function stateChanged() 
{ 
if (xmlHttp.readyState==4 || xmlHttp.readyState=="complete")
 { 
 document.getElementById(str).innerHTML=xmlHttp.responseText 
 } 
}

[COLOR="Red"]}[/COLOR]

you can then make the xhr object local, which is a probably good idea as well

[venegal]

Sorry, I didn't mention that in my post above:
stateChangedStr calls stateChanged with the parameter str now, so you will have to make it accept that parameter:

function stateChanged(str)
{ 
if (xmlHttp.readyState==4 || xmlHttp.readyState=="complete")
 { 
 document.getElementById(str).innerHTML=xmlHttp.responseText 
 } 
}

[rnd me]

Sorry, I didn't mention that in my post above:
stateChangedStr calls stateChanged with the parameter str now, so you will have to make it accept that parameter:

function stateChanged(str)
{ 
if (xmlHttp.readyState==4 || xmlHttp.readyState=="complete")
 { 
 document.getElementById(str).innerHTML=xmlHttp.responseText 
 } 
}

Why, just remove the param so that the stateChanged doesn't have it's own copy, and inherits "str" from getspecial...

or, dupe it, and allow either:

function stateChanged(str2){
  var str=str2||str;

[venegal]

str is scoped within getspecial, stateChanged will never inherit it, that's what the original problem is all about, and that's why passing str around is even necessary. I've been a bit sloppy before though, here's the revised code:

function getspecial(str){
	stateChangedStr = function(){
		stateChanged(str);
	};

	var xmlHttp=GetXmlHttpObject()
	if (xmlHttp==null){
		alert ("Browser does not support HTTP Request");
		return;
	}
	
	var url = "index.php/home/getSpecial/";
	url = url + str;
	
	xmlHttp.onreadystatechange = stateChangedStr;
	xmlHttp.open("GET",url,true);
	xmlHttp.send(null);
}
function stateChanged(str){ 
	if (xmlHttp.readyState == 4 || xmlHttp.readyState == "complete"){ 
		document.getElementById(str).innerHTML = xmlHttp.responseText;
	} 
}

If you're feeling comfortable polluting your global namespace, you could of course always just declare var globalStr; outside of any function, set it in getspecial to globalStr = str;, use it in statechanged document.getElementById(globalStr).innerHTML=xmlHttp.responseText and apart from that use your original code. I guess that's what you originally had in mind.

[beedie]

So this this works but.. for some reason which is in another post it won't send the variables in the post.

function getspecial(str)
{
  
xmlHttp=GetXmlHttpObject()
if (xmlHttp==null)
 {
 alert ("Browser does not support HTTP Request")
 return
 }
var url="index.php/home/getSpecial/"
url=url+str

xmlHttp.onreadystatechange=stateChanged 
xmlHttp.open("GET",url,true)
xmlHttp.send(null)
var div = str.substr(6,1);
function stateChanged() 
{ 
if (xmlHttp.readyState==4 || xmlHttp.readyState=="complete")
 { 
 document.getElementById(div).innerHTML=xmlHttp.responseText 
 } 
}
}

Here is the relevant post:
http://codingforum.net/showthread.php?t=164069